Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build in MSYS shell #34

Open
nikserg opened this issue Jan 17, 2022 · 1 comment
Open

Does not build in MSYS shell #34

nikserg opened this issue Jan 17, 2022 · 1 comment

Comments

@nikserg
Copy link

nikserg commented Jan 17, 2022

Trying to build using MSYS shell, but get error, which clearly says, that I'm using MSYS, but it expects MSYS, lol.

$ go run build.go -verbose build-all
2022/01/17 11:56:59 This has to be run in a MSYS or MinGW64 shell, uname output: MSYS_NT-10.0-19042 PK011 3.3.3-341.x86_64 2022-01-16 14:36 UTC x86_64 Msys
exit status 1
@cretz
Copy link
Owner

cretz commented Jan 17, 2022

} else if !bytes.HasPrefix(byts, []byte("MINGW64")) && !bytes.HasPrefix(byts, []byte("MSYS2")) {
is expecting MINGW64 or MSYS2. Seems others have included "MSYS_NT", e.g. https://github.com/conan-io/conan/pull/2798/files. I am ok with a PR that does the same here if you're willing to submit it. Otherwise, I haven't really updated this project in years and am unsure when I'll revisit it.

mibmo added a commit to mibmo/tor-static that referenced this issue Jun 17, 2022
mibmo added a commit to mibmo/tor-static that referenced this issue Jun 17, 2022
mibmo added a commit to mibmo/tor-static that referenced this issue Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants