CI/CD #35
CI/CD #35
Conversation
they were kinda preventing macos from building correctly, so...
|
I'm struggling quite a bit with getting Mac builds to work (at all). Could someone knowledgeable perhaps pitch in? |
|
I did get mac builds working once (as well as those locally on my machine), but that requires updating the pinned Tor version (the latest commit works just fine). How would you feel about that, @cretz? Seems like it'd be a good thing to update it anyway, as it's pretty out of date. |
What version? Can you make sure the integration test at the root of the repo ( Also, once we merge master the workflows should start running (I have enabled actions on this repo). And we can remove the other CI stuff. Thanks for doing this! |
Tor 0.4.7.7
Since tests rely on Bine, I think we'd need an additional PR to Bine to support the bump in version ( Updating the Tor version might end up being a bigger change (not sure though), so I've split it into a different PR, #36.
Sounds good! :D |
seems like they're the "standard", and this allows for flexibility in specifying runner OS versions.
this is to allow for running tests afterwards. gh actions don't support cross-file workflow dependencies yet.
also cleans up env a bit; some unnecessary envvars were leftover from copy-pasting the action from another project
this is needed for running tests
|
I have a Mac! I tried the binary from your build and it worked. It connected to the Tor network (Bootstrapped 100%), no problem. I had to remove the Mac quarantine attributes from the binary, but I believe that's only because I downloaded it via my browser from GitHub Actions. If you download the artifact via curl then they artifacts won't be there. xattr -d com.apple.quarantine tor
xattr -d com.apple.macl tor |
|
@milesrichardson - Thanks! @mibmo - This looks pretty good, shall I go ahead and merge? |
|
@milesrichardson: thank you so much for testing! glad to hear it worked. :) @cretz: almost! i'm gonna try getting windows to build first. |
the whole caching the PROJECT_HASH with actions/cache and diffing it is a bit jank but honestly i'd say that it's worth it.
|
|
mibmo
force-pushed
the
ci
branch
2 times, most recently
from
cabffc4
to
1e68214
Compare
|
@cretz: are you sure the windows guide in the readme is correct? i've a friend running windows following it step-by-step and they can't get it to build either? in any case, if this keeps posing an issue we could also just merge and do another PR on building for windows specifically. |
|
@mibmo - I am not sure, it may be outdated. What is your error? The important thing about Windows is that, like other CGo Windows dependencies, it has to be built with GCC. I support disabling Windows builds and doing in a separate PR if wanted. Can also look around to see how others build such libraries. |
|
@cretz: i think it might be a bit outdated, e.g. it was missing instructions on installing go; we had to do that manually. go is running fine though, output from running $ go run build.go build-all
2023/04/11 19:26:47 *** Building all ***
2023/04/11 19:26:47 *** Building openssl ***
2023/04/11 19:26:47 Running in folder openssl: perl ./Configure --prefix=/C/MSYS2/home/rasmu/tor-sta
tic/openssl/dist --openssldir=/C/MSYS2/home/rasmu/tor-static/openssl/dist no-shared no-dso no-zlib m
ingw64
2023/04/11 19:26:52 Running in folder openssl: make depend
2023/04/11 19:26:52 Running in folder openssl: make -j32
2023/04/11 19:26:52 *** Done building openssl ***
2023/04/11 19:26:52 *** Done building all ***
2023/04/11 19:26:52 exit status 2
exit status 1unless you know what's wrong and can help with a fix, i vote for just merging this and then we can open an issue for windows specifically — not having windows builds is really a shame though, it's the whole reason i started the pr, haha. edit: it's the same error that the CI is spewing rn :) check the windows build |
Automatic builds for the statically-linked binaries.
Checklist:
There are quite a few things I want to change, such as the artifact names and general structure, but this is a working first draft.
I'm thinking downloads will be available both through action artifacts & from the releases page (that requires another release be made, but that doesn't really have to happen till after this is completely done).
Note: I haven't really found a good workflow for incrementally developing actions, so you're likely to see a bunch of force-pushes to my repository. Not a whole lot I can do there, I'm afraid (act does exist, but I can't get it to run with Podman)
Resolves #13