Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onion creation and event listening race #39

Open
karalabe opened this issue Mar 22, 2020 · 1 comment
Open

Onion creation and event listening race #39

karalabe opened this issue Mar 22, 2020 · 1 comment

Comments

@karalabe
Copy link
Contributor

When starting an onion Listener, the library first requests the onion to be created, and only later does it start listening for events (https://github.com/cretz/bine/blob/master/tor/listen.go#L267). There's a chance that by the time it subscribes to events, listening has already been started (or failed). This will start Listen to hang.

I'm not sure if this is the issue I'm hitting in my project or not, but if I restart my Tor node and recreate an old onion, it almost always hangs.

@cretz
Copy link
Owner

cretz commented Jun 13, 2021

Will look to moving event capture asynchronous and before the sending of the conf. Same at #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants