Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the tor dos window on windows #33

Closed
dballard opened this issue Sep 26, 2019 · 4 comments
Closed

Hide the tor dos window on windows #33

dballard opened this issue Sep 26, 2019 · 4 comments

Comments

@dballard
Copy link
Contributor

PR #32 is to address this.

On Windows when Bine is starting Tor it creates a permanent dos console window. This PR mostly hides it (there is a brief blink into existence for it and then it's hidden). Looks a lot nicer and other OSs like Linux do not have this issue of a terminal being opened for a Tor process

@cretz
Copy link
Owner

cretz commented Sep 27, 2019

Does it also create this window when starting from cmd or only via GUI situations (I personally haven't experienced it in my CLI apps)? Also, is this Tor version specific? What is the harm of this on existing CLI apps? Finally, I would like to make this opt-in, so maybe a type CmdCreatorFunc func(ctx context.Context, exePath string, args ...string) (*exec.Cmd, error) that implements Creator so that people can create the command any way they want instead of just this specific change.

@lu4p
Copy link
Contributor

lu4p commented Nov 5, 2019

You may need to compile your code with go build -ldflags '-H windowsgui' which should hide any such windows.

@dballard
Copy link
Contributor Author

haha thanks @lu4p but that did the opposite of what I needed. It hide my app's window but the tor dos console still popped up :)
I'll try these fixes certz has suggested just as soon as I can get building on windows working for me (unrelated toolchain problem therecipe/qt#909)

@blakeyi
Copy link

blakeyi commented Jan 21, 2022

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants