Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot error in stories with popups/modals #150

Open
varya opened this issue May 20, 2021 · 1 comment
Open

Screenshot error in stories with popups/modals #150

varya opened this issue May 20, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@varya
Copy link
Contributor

varya commented May 20, 2021

I get an error for this story https://component-library-storybook.dc2-dev.elisa.fi/?path=/story/components-modal--size-s

2021-05-20_16-57-05

The reason to it must be that div#root is 0 pixels of height. But that might be the case with all the modals/popups.

@wKich wKich added the bug Something isn't working label May 21, 2021
@wKich
Copy link
Collaborator

wKich commented May 21, 2021

Yep. I know about this issue. I'm going to change the default algorithm of resolving a captureElement, so it will work the same as in Chromatic. For now, you can explicitly set captureElement to null or body for those stories.

sol-un pushed a commit to moira-alert/web2.0 that referenced this issue Oct 28, 2022
for further detail, see creevey/creevey#150
sol-un pushed a commit to moira-alert/web2.0 that referenced this issue Oct 28, 2022
sol-un pushed a commit to moira-alert/web2.0 that referenced this issue Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants