Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove specific pipenv version restriction #203

Closed
TimidRobot opened this issue Nov 8, 2021 · 0 comments · Fixed by #222
Closed

[Bug] Remove specific pipenv version restriction #203

TimidRobot opened this issue Nov 8, 2021 · 0 comments · Fixed by #222
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@TimidRobot
Copy link
Member

Description

PR #201 added a specific version of pipenv (2021.5.29). This was required as the current version of pipenv (2021.11.5.post0) does not work well on Ubuntu 20.04, which is the current default for GitHub Actions.

Reproduction

See pypa/pipenv#4833 and PR #201 GitHub Action logs.

Expectation

We should be able to use the latest version of pipenv (once it is not broken).

Once pipenv has been fixed, the specific version should be removed:

--- .github/workflows/pre-commit.yml
+++ .github/workflows/pre-commit.yml
@@ -61,12 +61,9 @@ jobs:
         python-version: "3.7"
 
     - name: Install pipenv
-      # Use pipenv 2021.5.29 to circumvent errors with 2021.11.5.post0 on
-      # Ubuntu 20.04
-      # https://github.com/pypa/pipenv/issues/4833
       run: |
         python -m pip install --upgrade pip
-        python -m pip install pipenv==2021.5.29
+        python -m pip install pipenv
 
     - name: Install Python dependencies
       run: |

Environment

Additional context

@TimidRobot TimidRobot added 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Nov 8, 2021
@TimidRobot TimidRobot added this to Pending Review in Backlog via automation Nov 8, 2021
@TimidRobot TimidRobot moved this from Pending Review to License Infrastructure in Backlog Nov 8, 2021
@TimidRobot TimidRobot linked a pull request Dec 7, 2021 that will close this issue
7 tasks
@TimidRobot TimidRobot added this to Done in Active Sprint Feb 14, 2022
@TimidRobot TimidRobot removed this from License Infrastructure in Backlog Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work
Projects
Active Sprint
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant