Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support adding keys to ssh-agent #70

Open
jasonkarns opened this issue Dec 22, 2020 · 2 comments
Open

Feature request: support adding keys to ssh-agent #70

jasonkarns opened this issue Dec 22, 2020 · 2 comments

Comments

@jasonkarns
Copy link

For users that use gpg keys for ssh auth, it would be amazing if this action also set up for forwarding of ssh-agent to gpg-agent such that we could use our gpg keys for SSH auth.

@crazy-max
Copy link
Owner

@jasonkarns LGTM, I think we would only need to add enable-ssh-support to gpg-agent conf and maybe specify keys in gnupg sshcontrol but we would need to handle keygrips somehow. Last we have to tell SSH how to access the gpg-agent. Maybe use SSH_AUTH_SOCK for that.

@jasonkarns
Copy link
Author

I've realized later that this probably won't work for my primary use case...

My thought was to have a single gpg key for signing+auth which would be installed using this action. The signing key would be used to sign git commits, and the auth key would be used for authenticating with github for the push/pull.

However, there's a bit of a catch-22. This action must run after the checkout action, in order to support setting the gpg signing key. However, it would need to run before the checkout action if one wanted to provide the auth key to the checkout action via the ssh-key parameter.

So while I still think there may be some utility here, my personal interest has waned a bit. Unless this feature were to "double up" on whatever the checkout action's ssh-key param is doing (and thereby cut the catch-22 loop).

@stale stale bot added the status/stale label Jan 22, 2021
@github-actions github-actions bot removed the ✋ hold label Mar 18, 2021
Repository owner deleted a comment from stale bot May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants