Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pull_request_target event #97

Merged
merged 1 commit into from May 25, 2021
Merged

Conversation

crazy-max
Copy link
Member

Fixes #96

cc @mithro

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@codecov-commenter
Copy link

Codecov Report

Merging #97 (d05cc58) into master (013e892) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   77.21%   77.15%   -0.07%     
==========================================
  Files           5        5              
  Lines         338      337       -1     
  Branches       80       80              
==========================================
- Hits          261      260       -1     
  Misses          3        3              
  Partials       74       74              
Impacted Files Coverage Δ
src/meta.ts 76.02% <50.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013e892...d05cc58. Read the comment docs.

@mithro
Copy link

mithro commented May 25, 2021

LGTM, should it have a test though?

@crazy-max
Copy link
Member Author

@mithro

LGTM, should it have a test though?

Yes I will add a bunch of tests before merging ;)

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max merged commit 98669ae into docker:master May 25, 2021
@crazy-max crazy-max deleted the fix-pr-event branch May 25, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pull_request_target triggers the event=branch when it should only trigger on event=pr
3 participants