Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appending option to tags #13

Closed
kereis opened this issue Nov 10, 2020 · 9 comments · Fixed by #50
Closed

Add appending option to tags #13

kereis opened this issue Nov 10, 2020 · 9 comments · Fixed by #50

Comments

@kereis
Copy link

kereis commented Nov 10, 2020

Let's say you build multiple distro flavors of your Docker image, e. g. one in Ubuntu (main) and one in Alpine.
Meanwhile it's fine to use the usual tagging for the main image, is there a way of setting a "base tag" or a "tag" to be appended? In this case, for the Alpine flavor, instead of latest, using alpine, x.x.x-alpine etc. is more appropriate.

@mblaschke
Copy link

also interested in prefix/suffix

@jgustie
Copy link
Contributor

jgustie commented Nov 20, 2020

I thought I could fake this with sep-tags: -alpine, in the meta action and setting tags: ${{ steps.docker_meta.outputs.tags }}-alpine in the build push action, however it looks like the sep-tags is also being used on the labels which is causing the image to get a single label (fixed in #17).

@slimcdk
Copy link

slimcdk commented Nov 24, 2020

Also interested in tag pre/suffixes

@LongLiveCHIEF
Copy link

I'm going to open an issue or two, and even see about contributing a few of the features from an action I wrote a while back (HackerHappyHour/tagging-strategy that has the options being asked about here.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@whyman
Copy link

whyman commented Feb 3, 2021

+1 for prefix/suffix on tags

@lpil
Copy link

lpil commented Feb 14, 2021

Hi all! Is there a workaround for this?

@kereis
Copy link
Author

kereis commented Feb 15, 2021

Hi all! Is there a workaround for this?

Hey, you can take a look at my workflow file for traefik-certs-dumper. I haven't tested it throughly though.

@LongLiveCHIEF
Copy link

You can use the HackerHappyHour/tagging-strategy@v3 action for this in the meantime while #30 is being considered.

For live examples of this see https://github.com/OctoPrint/octoprint-docker/blob/master/.github/workflows/octoprint-release.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants