Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve Docker image entry #639

Merged
merged 1 commit into from Dec 19, 2022
Merged

feat: Improve Docker image entry #639

merged 1 commit into from Dec 19, 2022

Conversation

scop
Copy link
Contributor

@scop scop commented Dec 18, 2022

Make typos the ENTRYPOINT rather than cmd, and output --help by default.

Provides for better UX when running the image without arguments, and facilitates just passing args to typos instead of having to repeat the command name.

BREAKING CHANGE: typos must no longer given as the first argument when running the Docker image, as it is the default ENTRYPOINT now.

Make `typos` the `ENTRYPOINT` rather than cmd, and output `--help` by
default.

Provides for better UX when running the image without arguments, and
facilitates just passing args to `typos` instead of having to repeat the
command name.

BREAKING CHANGE: `typos` must no longer given as the first argument
when running the Docker image, as it is the default `ENTRYPOINT` now.
@epage epage merged commit 51f0b65 into crate-ci:master Dec 19, 2022
@scop scop deleted the feat/docker-entrypoint branch December 20, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants