fix: Docker/Debian version sync #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rust:1.65.0` is based on Bullseye, and at time of writing the binary
built on it does not work on Buster:
```
$ docker build -t typos . && docker run --rm -it typos typos -V
typos: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.29' not found
(required by typos)
```
Use `bullseye` explicitly to make the correspondence with the final image clear, and remove explicit Rust version as it does not seem that important, and the final runtime image version is what it is at the time too.
Makes it overridable from CLI, and just one place to update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.
Regarding just using
bullseyeas the builder Rust image version, the unimportance of that is frankly just a guess. If there is some importance to it, could use e.g.rust:1.66-${DEBIAN_DIST}instead. Might require disabling Renovate's updates to this file, I don't know if it'd drop the-${DEBIAN_DIST}suffix on updates.