--exclude is not working

[sadikkuzu]

Hi,

--exclude is not working after v1.3.3

To reproduce:

docker run -it --rm python:latest bash -c '\
cd /tmp ; mkdir compare-133-160; cd $_; \
echo ; \
echo "+ pip install pre-commit" ; \
pip install -q pre-commit ; \
mkdir -p tests/fixtures ; \
mkdir -p tests/folder/fixtures ; \
mkdir -p src/constants ; \
echo "Comman" > ./src/constants/config.py
echo "assingment" > ./tests/folder/fixtures/file.txt ; \
echo "dummy_id = \"b8e718aa646b8a235ba11\"" > ./tests/fixtures/mock_objects.py ; \
typos-hook-1-3-3() { \
cat <<\EOF
repos:
-   repo: https://github.com/crate-ci/typos
    rev: v1.3.3
    hooks:
    -   id: typos
        verbose: true
        args: [
            "--exclude",
            "tests/*/fixtures",
            "tests/fixtures",
            "src/constants/config.py",
        ]
EOF
} ; \
echo ; \
echo "+ cat ./tests/fixtures/mock_objects.py" ; \
cat ./tests/fixtures/mock_objects.py ; \
echo ; \
echo "+ cat ./tests/folder/fixtures/file.txt" ; \
cat ./tests/folder/fixtures/file.txt ; \
echo ; \
echo "+ cat ./src/constants/config.py" ; \
cat ./src/constants/config.py ; \
echo ; \
typos-hook-1-3-3 > .pre-commit-config.yaml ; \
echo "+ cat ./.pre-commit-config.yaml" ; \
cat ./.pre-commit-config.yaml ; \
echo ; \
echo "*** 1.3.3 ***" ; \
git config --global init.defaultBranch main ; \
git init; git add . ; \
pre-commit run --all-files; \
echo ; \
echo "*** 1.6.0 ***" ; \
pre-commit autoupdate; \
git add -u ; \
pre-commit run --all-files;'

Result output is:

[epage]

So a basic thing that was fixed in 1.3.4 was a bug in our CLI parser that allowed --exclude v1 v2 v3. It now has to be --exclude v1 --exclude v2 --exclude v3.

However, even with that its not working in the container with pre-commit but is working when I run it directly. Still looking into that.

[epage]

Also, in general using exclude is broken with pre-commit, see #347, I'm just confused as to why it worked before.

[sadikkuzu]

Hi @epage
Thanks for fast reply.

Unfortunately --exclude v1 --exclude v2 --exclude v3 option didn't work well too.

docker run -it --rm python:latest bash -c '\
cd /tmp ; mkdir compare-133-160; cd $_; \
echo ; \
echo "+ pip install pre-commit" ; \
pip install -q pre-commit ; \
mkdir -p tests/fixtures ; \
mkdir -p tests/folder/fixtures ; \
mkdir -p src/constants ; \
echo "Comman" > ./src/constants/config.py
echo "assingment" > ./tests/folder/fixtures/file.txt ; \
echo "dummy_id = \"b8e718aa646b8a235ba11\"" > ./tests/fixtures/mock_objects.py ; \
typos-hook-1-3-3() { \
cat <<\EOF
repos:
-   repo: https://github.com/crate-ci/typos
    rev: v1.3.3
    hooks:
    -   id: typos
        verbose: true
        args: [
            "--exclude",
            "tests/*/fixtures",
            "--exclude",
            "tests/fixtures",
            "--exclude",
            "src/constants/config.py",
        ]
EOF
} ; \
echo ; \
echo "+ cat ./tests/fixtures/mock_objects.py" ; \
cat ./tests/fixtures/mock_objects.py ; \
echo ; \
echo "+ cat ./tests/folder/fixtures/file.txt" ; \
cat ./tests/folder/fixtures/file.txt ; \
echo ; \
echo "+ cat ./src/constants/config.py" ; \
cat ./src/constants/config.py ; \
echo ; \
typos-hook-1-3-3 > .pre-commit-config.yaml ; \
echo "+ cat ./.pre-commit-config.yaml" ; \
cat ./.pre-commit-config.yaml ; \
echo ; \
echo "*** 1.3.3 ***" ; \
git config --global init.defaultBranch main ; \
git init; git add . ; \
pre-commit run --all-files; \
echo ; \
echo "*** 1.6.0 ***" ; \
pre-commit autoupdate; \
git add -u ; \
pre-commit run --all-files;'

[sadikkuzu]

Also, in general using exclude is broken with pre-commit, see #347, I'm just confused as to why it worked before.

Looking forward to resolution of #347
Thanks

[sadikkuzu]

Maybe exclusion should be delegated to pre-commit
as mentioned in #347 (comment)

before

repos:
-   repo: https://github.com/crate-ci/typos
    rev: v1.6.0
    hooks:
    -   id: typos
        verbose: true
        args: [
            "--exclude",
            "tests/*/fixtures",
            "--exclude",
            "tests/fixtures",
            "--exclude",
            "src/constants/config.py",
        ]

after

repos:
-   repo: https://github.com/crate-ci/typos
    rev: v1.6.0
    hooks:
    -   id: typos
        verbose: true
        exclude: "fixtures|src/constants/config"

docker run -it --rm python:latest bash -c '\
cd /tmp ; mkdir compare-133-160; cd $_; \
echo ; \
echo "+ pip install pre-commit" ; \
pip install -q pre-commit ; \
mkdir -p tests/fixtures ; \
mkdir -p tests/folder/fixtures ; \
mkdir -p src/constants ; \
echo "Comman" > ./src/constants/config.py
echo "assingment" > ./tests/folder/fixtures/file.txt ; \
echo "dummy_id = \"b8e718aa646b8a235ba11\"" > ./tests/fixtures/mock_objects.py ; \
typos-hook-1-3-3() { \
cat <<\EOF
repos:
-   repo: https://github.com/crate-ci/typos
    rev: v1.3.3
    hooks:
    -   id: typos
        verbose: true
        exclude: "fixtures|src/constants/config"
EOF
} ; \
echo ; \
echo "+ cat ./tests/fixtures/mock_objects.py" ; \
cat ./tests/fixtures/mock_objects.py ; \
echo ; \
echo "+ cat ./tests/folder/fixtures/file.txt" ; \
cat ./tests/folder/fixtures/file.txt ; \
echo ; \
echo "+ cat ./src/constants/config.py" ; \
cat ./src/constants/config.py ; \
echo ; \
typos-hook-1-3-3 > .pre-commit-config.yaml ; \
echo "+ cat ./.pre-commit-config.yaml" ; \
cat ./.pre-commit-config.yaml ; \
echo ; \
echo "*** 1.3.3 ***" ; \
git config --global init.defaultBranch main ; \
git init; git add . ; \
pre-commit run --all-files; \
echo ; \
echo "*** 1.6.0 ***" ; \
pre-commit autoupdate; \
git add -u ; \
pre-commit run --all-files;'

[epage]

Yes, using precommit's exclusions is a workaround for this. The downside is it doesn't work with other uses of typos so you have to duplicate your config in both spots.

[epage]

Going ahead and closing this in favor of #347