Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom ignores? #134

Closed
epage opened this issue Aug 21, 2020 · 2 comments · Fixed by #136 or #255
Closed

Custom ignores? #134

epage opened this issue Aug 21, 2020 · 2 comments · Fixed by #136 or #255

Comments

@epage
Copy link
Collaborator

epage commented Aug 21, 2020

Some times files should just be ignore for spelling but work for all others
@epage
Copy link
Collaborator Author

epage commented Aug 21, 2020

https://docs.rs/ignore/0.4.16/ignore/struct.WalkBuilder.html

https://docs.rs/ignore/0.4.16/ignore/overrides/struct.OverrideBuilder.html

https://docs.rs/ignore/0.4.16/ignore/types/struct.TypesBuilder.html

epage pushed a commit to epage/typos that referenced this issue Aug 26, 2020
feat(ignore): Typos-specific ignores
e52f6b0 
THis is to help with cases like a monorepo with vendored dependencies.
A user might want to search (`.ignore`) them but not hold the code to
the same standards as first-party code.

Fixes crate-ci#134
@epage epage mentioned this issue Aug 26, 2020
Merged
epage pushed a commit to epage/typos that referenced this issue Aug 26, 2020
feat(ignore): Typos-specific ignores
0052617 
THis is to help with cases like a monorepo with vendored dependencies.
A user might want to search (`.ignore`) them but not hold the code to
the same standards as first-party code.

Fixes crate-ci#134
@epage epage reopened this Nov 4, 2020
epage pushed a commit to epage/typos that referenced this issue Nov 5, 2020
Revert "feat(ignore): Typos-specific ignores"
2ef1d02 
This reverts commit 0052617.

The fix for crate-ci#134 was backwards.  It turns out `overrides` is for
including rather than ignoring.  Will need to look at this further.
@epage
Copy link
Collaborator Author

epage commented Apr 15, 2021

#193 might be another way of doing this (a config file deeper in turning off checking of files or file names)

epage pushed a commit to epage/typos that referenced this issue May 21, 2021
feat(ignore): Typos=specific ignores
327a84a 
We want both CLI and config ignores.  The question then is what we make
them relative to.  I decided to favor CLI with `.`.  We'll see how this
works out

Fixes crate-ci#134
@epage epage mentioned this issue May 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@epage