Ability to get the Command from CargoBuild

[ronnychevalier]

The API of CargoBuild does not allow us to get the inner Command it is building.
We can only run the Command with exec().

Having access to a method like into_command() (or something similar) can be useful if another crate requires a &mut Command to do something.

[epage]

So if I understand, the intention is to use escargot API to help generate the flags for cargo build but you wouldn't then want the other half, of parsing the output?

[ronnychevalier]

So if I understand, the intention is to use escargot API to help generate the flags for cargo build but you wouldn't then want the other half, of parsing the output?

No, I would still use the parsing of the output.

For example, with the following code:

let cargo = CargoBuild::new().manifest_path(...).arg(...);
let mut command = cargo.into_command();

// Function that modifies `Command` to add args or env variables.
other_crate::Struct::function(&mut command);

let r = CommandMessages::with_command(command);

The only missing piece is something that returns the inner Command from CargoBuild.
We could even have another function that just returns the &mut Command:

let cargo = CargoBuild::new().manifest_path(...).arg(...);

// Function that modifies `Command` to add args or env variables.
other_crate::Struct::function(cargo.command_mut());

let r = cargo.exec();

[epage]

Thanks for the further explanation. Feel free to put up a PR for into_command for all of the command-owning types.