Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CargoBuild): add env method to add environment variable to the cargo cmd #43

Merged
merged 1 commit into from Mar 25, 2021

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Mar 25, 2021

No description provided.

…argo cmd

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@epage epage merged commit 9b6964d into crate-ci:master Mar 25, 2021
@epage
Copy link
Contributor

epage commented Mar 25, 2021

Thanks for contributing this!

I assume you'll need a release created?

Also, if there are standard env vars you'll be using, may I recommend also adding those to the API?

@bnjjj
Copy link
Contributor Author

bnjjj commented Mar 26, 2021

Yes for the release please. But no rush if you need to add more into the release I can keep using my fork for now. I'm not sure to understand your question about the API ? :D

@epage
Copy link
Contributor

epage commented Mar 27, 2021

I'm not sure to understand your question about the API ? :D

I'm curious what environment variables you are needing to pass in. If they are ones defined by rust / cargo, like RUST_TRACEBACK, then maybe we should also create functions directly for them so people have a type safe wrapper around them, kind of like how escargot creates wrappers around just adding --some-flag.

@epage
Copy link
Contributor

epage commented Mar 27, 2021

v0.5.2 is now published.

@bnjjj
Copy link
Contributor Author

bnjjj commented Mar 27, 2021

Oh ok sorry. Thanks a lot for the release. No it was for a specific environment variable needed for my project when using env! macro. So nothing really related to a cargo/rustc environment variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants