Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: check allowed authors #353

Open
scop opened this issue Nov 16, 2023 · 3 comments
Open

RFE: check allowed authors #353

scop opened this issue Nov 16, 2023 · 3 comments
Labels
enhancement Improve the expected

Comments

@scop
Copy link
Contributor

scop commented Nov 16, 2023

A check for allowed authors would be nice, for example so that projects wanting committers to use their project/organization related e-mail addresses for commits could check that.

I think a regex config option and related (inverse) matching similar to ignore_author_re could be used for this.

@scop scop changed the title RFE: check author e-mail RFE: check allowed authors Nov 16, 2023
@epage
Copy link
Collaborator

epage commented Nov 16, 2023

Mind writing up a proposed schema with an example of what data it would allow/disallow and what that message would look like?

@scop
Copy link
Contributor Author

scop commented Nov 19, 2023

Mini-PR in #354 -- feel free to reuse that and the associated branch for the implementation if you're taking this on.

  • The regex would be matched against the commit author (whole string), just like ignore_author_re.
  • If the regex matches, all good, no messages.
  • If it does not match, would cause an error with a message like
    Commit author `{}` does not match allowed regular expression `{}`
    

@epage epage added the enhancement Improve the expected label Nov 27, 2023
@epage
Copy link
Collaborator

epage commented Nov 27, 2023

Seems reasonable if someone wants to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

2 participants