Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-release-replacements and hooks #768

Open
tisonkun opened this issue Mar 23, 2024 · 5 comments
Open

post-release-replacements and hooks #768

tisonkun opened this issue Mar 23, 2024 · 5 comments

Comments

@tisonkun
Copy link

My scenario:

  • Pre-release: Change "latest" to "{{version}}".
  • Post-release: Change back to "latest".

So that my main branch will use "latest" automatically instead of requiring manually edition.

I'd firstly seek for a consensus and would try to implement it if desired. I suppose it's similar to the pre-release ones.

@epage
Copy link
Collaborator

epage commented Mar 24, 2024

Could you give an example of where you use latest that you need this kind of behavior?

@tisonkun
Copy link
Author

tisonkun commented Mar 24, 2024

https://github.com/korandoru/hawkeye/blob/v5.1.0/release.py

@epage Currently I wrap the logic in a simple script. The logic is almost file content replacement.

Another issue is that the replacement/hook search path is always from package root which is not quite suitable for workspace case. But this is not a blocked for me since the action is idempotent and I can use "../xxx"

@tisonkun

This comment was marked as outdated.

@epage
Copy link
Collaborator

epage commented Mar 25, 2024

So in your case, you have a github action that references a docker image on dockerhub. Within the tagged release, you want to reference the tagged docker image. Outside of the tagged release, you want to reference an edge image.

Did I get that right?

@tisonkun
Copy link
Author

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants