Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--unpublished flag doesn't work with private registries. #670

Open
emilycf-cw opened this issue Apr 21, 2023 · 3 comments
Open

--unpublished flag doesn't work with private registries. #670

emilycf-cw opened this issue Apr 21, 2023 · 3 comments
Labels
bug Not as expected

Comments

@emilycf-cw
Copy link

The --unpublished flag only skips crates which are published in the crates.io registry. If I am instead using a private registry, none of my crates will be published there, so this flag does nothing.

@scullionw
Copy link

i'm having the same issue

@scullionw
Copy link

@epage is this expected behaviour?

@epage
Copy link
Collaborator

epage commented Jun 27, 2023

It is not. In general, custom registry support is weak as I don't have any scenarios I can test it on.

Minimum Steps

  • Convert registry names to registry URLs using this cargo-edit code
  • Correctly initialize crates_index::Index from the correct URL

Next-level steps

  • Mirror cargo in determining the default registry that should be used for publish

Related #368

@epage epage added the bug Not as expected label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not as expected
Projects
None yet
Development

No branches or pull requests

3 participants