Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: post-release-hook #434

Open
Person-93 opened this issue Mar 29, 2022 · 6 comments
Open

Feature request: post-release-hook #434

Person-93 opened this issue Mar 29, 2022 · 6 comments
Labels
enhancement Improve the expected

Comments

@Person-93
Copy link
Contributor

Is running a post release hook within the scope of this project? I see that it's mentioned here as something that might be considered. Would you accept a PR that implements it?

My use case is to push additional git tags. If the new version is 2.6.22, I'd want three tags applied to that commit: v2, v2.6, and v2.6.22. The last one is already handled by cargo-release, but I'd like to add some custom logic at the end of the process for the other two tags.

@epage
Copy link
Collaborator

epage commented Mar 29, 2022

post-release hook sounds reasonable.

@epage epage added the enhancement Improve the expected label Mar 29, 2022
@psandana
Copy link

@epage do you have a "workflow" in mind to combine GitHub Releases, GitHub Actions and the usage of Cargo Release? Maybe worth document it, as someone can automate the creation of tags starting from GitHub Releases.

@epage
Copy link
Collaborator

epage commented Apr 17, 2024

We have a FAQ entry for that: https://github.com/crate-ci/cargo-release/blob/master/docs/faq.md#how-do-i-automate-creating-a-release-on-github

@psandana
Copy link

@epage, is there a way to create annotated tags instad of lightweight tags?

@epage
Copy link
Collaborator

epage commented Apr 17, 2024

They should be annotated; we pass -a

@psandana
Copy link

They should be annotated; we pass -a

False alarm. I was not pushing the tag, but later using gh release which added a non-annotated tag. Thanks for the support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

3 participants