Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace existing prerelease suffix #4

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

rbury
Copy link
Contributor

@rbury rbury commented May 30, 2020

When a prerelease suffix has not been specified use the existing suffix, then use the default when no existing suffix is found.

When a prelease suffix has been specified use this suffix to override both existing and default suffix.

This would allow the behavior of creating alpha releases, moving to beta releases etc. without manually creating a tag to change future suffix. This also ensures changes in these tags are consistent, formatting etc.

Example:
Repo with existing last tag v0.1.0-alpha.12

Run ./.github/actions/compute-tag
  with:
    github_token: ***
    version_scheme: semantic
    version_type: prerelease
    prerelease_suffix: beta

Computing the next tag based on: v0.1.0-alpha.12
Computed the next tag as: v0.1.0-beta.0 

When specified with variable, use specified value
Copy link
Owner

@craig-day craig-day left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Sorry for the delay in getting to this.

action.js Outdated Show resolved Hide resolved
Change to null/empty check
action.js Outdated Show resolved Hide resolved
@craig-day craig-day merged commit da84075 into craig-day:master Dec 4, 2020
@craig-day craig-day linked an issue Feb 13, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prerelease_suffix not applied
2 participants