Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Asset thumbnails and image inside the editor are not updated/refreshed when using the image editor to make a change, such as flipping the image. #12603

Closed
terryupton opened this issue Feb 1, 2023 · 5 comments
Assignees

Comments

@terryupton
Copy link

What happened?

Description

When you make a change to an asset in the image edit, these changes are not reflected inside the CMS and the original thumbnails and image inside the editor panel are cached.

Steps to reproduce

  1. Open an image inside the asset panel from the thumnails.
  2. Click to edit the image and open the image edit.
  3. Make a simple change, for example flip the image.

Here is a video to illustrate the issue and the process.

Craft-4-asset-issue-not-refreshing-updating.mov

Expected behavior

After editing the image, I would expect the following to update and show the image changes:

  1. The image inside the editor
  2. The thumbnail image in the slide out panel.
  3. The image in the asset listing panel.

Actual behavior

None of the images inside Craft are updating.
If I load the thumbnail in a browser and refresh the image, I see this change in the CMS, but ONLY inside the slide out panel.

When testing this locally, I see the same issues. However, locally I do see the image in the slide out panel update immediately. This is could perhaps be down to expires headers. However, it would be nice to resolve this if they are present and set.

Craft CMS version

Craft Pro 4.3.6.1

PHP version

8.1.14

Operating system and version

Linux 5.15.0-56-generic

Database type and version

MySQL 8.0.32

Image driver and version

magick 3.7.0 (ImageMagick 6.9.11-60)

Installed plugins and versions

@brandonkelly
Copy link
Member

Thanks for reporting that! The issue is that asset thumbnails weren’t getting versioned unless the revAssetUrls config setting was enabled, so your browser would continue loading the cached version. I’ve fixed this for the next release - going forward all CP thumbnails will be versioned regardless of the config setting.

@brandonkelly
Copy link
Member

Craft 4.3.7 has been released with that fix.

@terryupton
Copy link
Author

Hey @brandonkelly - thanks for this.
However, I am still seeing the same issue on the image that appears on the image editor.
the thumbnails and everything now updates, but not the image when you go back into the image to edit it after making a change (rotation etc).

Thanks.

brandonkelly added a commit that referenced this issue Feb 8, 2023
@brandonkelly
Copy link
Member

@terryupton Doh, thanks for pointing that out. That’s been fixed for the next release as well.

@brandonkelly
Copy link
Member

4.3.8.1 is out with that fix. Note that if you updated to 4.3.8 already, via the control panel, you will be affected by this bug, which was also fixed in 4.3.8.1. If so you will need to run composer update to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants