Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceError: assignment to undeclared variable baseUrls #80

Closed
yumetodo opened this issue Jan 5, 2018 · 6 comments
Closed

ReferenceError: assignment to undeclared variable baseUrls #80

yumetodo opened this issue Jan 5, 2018 · 6 comments
Labels

Comments

@yumetodo
Copy link
Member

yumetodo commented Jan 5, 2018

ReferenceError: assignment to undeclared variable baseUrls
[詳細]
kunai-vendor.js:24:352714
<匿名関数>
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:24:352714
<匿名関数>
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:24:336940
<匿名関数>
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:24:336904
t
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:1:96
<匿名関数>
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:24:116228
t
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:1:96
<匿名関数>
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:24:108525
t
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:1:96
<匿名関数>
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:24:90418
t
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:1:96
window.Kunai<[172]/<
https://cpprefjp.github.io/static/kunai/js/kunai.js:1:8253
window.Kunai<[172]
https://cpprefjp.github.io/static/kunai/js/kunai.js:1:8009
t
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:1:96
window.Kunai<[171]/<
https://cpprefjp.github.io/static/kunai/js/kunai.js:1:6691
window.Kunai<[171]
https://cpprefjp.github.io/static/kunai/js/kunai.js:1:6575
t
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:1:96
window.Kunai<[167]
https://cpprefjp.github.io/static/kunai/js/kunai.js:1:6105
t
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:1:96
window.Kunai<[118]/<
https://cpprefjp.github.io/static/kunai/js/kunai.js:1:1568
window.Kunai<[118]
https://cpprefjp.github.io/static/kunai/js/kunai.js:1:1397
t
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:1:96
window.webpackJsonpKunai
https://cpprefjp.github.io/static/kunai/js/kunai-vendor.js:1:428
<匿名関数>
https://cpprefjp.github.io/static/kunai/js/kunai.js:1:14
ReferenceError: Kunai is not defined
[詳細]
cpprefjp.github.io:52:9
<匿名関数>
https://cpprefjp.github.io/:52:9
@yumetodo yumetodo added the bug label Jan 5, 2018
@melpon
Copy link
Member

melpon commented Jan 5, 2018

marked のバージョンを上げてセキュリティ問題を直したつもりだったんだけど、新しいバージョンで普通にバグってるっぽい… markedjs/marked#990

melpon added a commit that referenced this issue Jan 5, 2018
@melpon
Copy link
Member

melpon commented Jan 5, 2018

とりあえず revert しておきました。
marked が更新されたらまた新しいバージョンで試す予定なので、この issue はまだ残しておきます。

@yumetodo
Copy link
Member Author

yumetodo commented Jan 6, 2018

これ、crsearchの方のdependencyいじってくるべきだった気がします・・・

ref:

@melpon
Copy link
Member

melpon commented Jan 6, 2018

今は crsearch の dependency を更新して、crsearch のバージョンを上げて npm publish し、kunai でその上がったバージョンを利用するようにしてるのですが、それでいいんですよね?

@melpon
Copy link
Member

melpon commented Jan 6, 2018

ああ、crsearch のコミットを revert した方がいいって話ですかね?
一度 publish したので、revert したのをまた publish し、直ったらまた publish するのが面倒だったので、どうせ今は kunai 以外は使ってないだろうから放置しています。

@melpon
Copy link
Member

melpon commented Jan 11, 2018

直ったので Close

@melpon melpon closed this as completed Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants