Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New route GET /settings/bitwarden for consistency #3864

Open
zatteo opened this issue Mar 31, 2023 · 0 comments · Fixed by cozy/cozy-client#1339
Open

New route GET /settings/bitwarden for consistency #3864

zatteo opened this issue Mar 31, 2023 · 0 comments · Fixed by cozy/cozy-client#1339

Comments

@zatteo
Copy link
Contributor

zatteo commented Mar 31, 2023

Hey,

Do you think it is possible to add a route /settings/bitwarden to get io.cozy.settings.bitwarden document from io.cozy.settings database for consistency with other routes ?

Because currently we can't fetch this document with cozy-client query Q('io.cozy.settings').getById('io.cozy.settings.bitwarden') as is where as we can do Q('io.cozy.settings').getById('io.cozy.settings.instance').

See https://github.com/cozy/cozy-client/blob/fd111e1f673a3b82d9d2899f07590582ca5326a4/packages/cozy-stack-client/src/SettingsCollection.js#L36

Not really important, I will in any case make a quick fix on cozy-client to support current route /data/io.cozy.settings/io.cozy.settings.bitwarden, but I think worth noting for consistency.

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants