Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for merging results #186

Merged
merged 2 commits into from Sep 6, 2018
Merged

Add support for merging results #186

merged 2 commits into from Sep 6, 2018

Conversation

tonerdo
Copy link
Collaborator

@tonerdo tonerdo commented Sep 2, 2018

Fixes #36

@codecov
Copy link

codecov bot commented Sep 2, 2018

Codecov Report

Merging #186 into master will decrease coverage by 3.91%.
The diff coverage is 13.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
- Coverage   98.93%   95.01%   -3.92%     
==========================================
  Files          15       15              
  Lines        1497     1564      +67     
==========================================
+ Hits         1481     1486       +5     
- Misses         16       78      +62
Impacted Files Coverage Δ
src/coverlet.core/CoverageResult.cs 16.21% <0%> (-83.79%) ⬇️
src/coverlet.core/Coverage.cs 99.42% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735daa4...d8d7388. Read the comment docs.

@tonerdo tonerdo merged commit 307d33b into master Sep 6, 2018
@Jenan
Copy link

Jenan commented Sep 7, 2018

Could you provide some details how to use this new feature? :)
Thanks

@tonerdo
Copy link
Collaborator Author

tonerdo commented Sep 9, 2018

@Jenan

Merging Documentation:
https://github.com/tonerdo/coverlet#merging-results
https://github.com/tonerdo/coverlet#merging-results-1

@MortenChristiansen
Copy link

The merge option only works with the native json format. How would I merge results in the cobertura format?

@MortenChristiansen
Copy link

I got it working by outputting both the cobertura and json formats, though it required me to create a json coverage file containing {} first. Otherwise the first project in the solution fails as it has nothing to merge with.

@tonerdo
Copy link
Collaborator Author

tonerdo commented Oct 11, 2018

Merging with non coverlet json formats might not ever be a supported option. It's way more easier with the coverlet json because it's just a serialization of the internal CoverageResult object. Other formats require more pre-processing and some information is lost in translation

NorekZ pushed a commit to NorekZ/coverlet that referenced this pull request Nov 8, 2018
@tonerdo tonerdo deleted the feature/merge-results branch December 8, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants