Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverlet.collector: upgraded from 3.1.0 to 6.0.0 but still Newtonsoft.Json.9.0.1 is coming in coverlet.collector.deps.json #1611

Closed
shaikhdastgir91 opened this issue Feb 9, 2024 · 6 comments
Labels
duplicate This issue or pull request already exists Solved The issue is solved and can be closed

Comments

@shaikhdastgir91
Copy link

Newtonsoft.Json.9.0.1 has some security issues. when Vera code is scanning our application then it is finding
Newtonsoft.Json.9.0.1 in coverlet.collector.deps.json. please remove these dependencies or upgrade to latest version of Newtonsoft.json

"Microsoft.Extensions.DependencyModel/2.1.0": { "dependencies": { "Microsoft.DotNet.PlatformAbstractions": "2.1.0", "Newtonsoft.Json": "9.0.1", "System.Diagnostics.Debug": "4.0.11", "System.Dynamic.Runtime": "4.0.11", "System.Linq": "4.1.0" }, "runtime": { "lib/netstandard1.6/Microsoft.Extensions.DependencyModel.dll": { "assemblyVersion": "2.1.0.0", "fileVersion": "2.1.0.0" } } },
"Newtonsoft.Json/9.0.1": { "dependencies": { "Microsoft.CSharp": "4.0.1", "System.Collections": "4.0.11", "System.Diagnostics.Debug": "4.0.11", "System.Dynamic.Runtime": "4.0.11", "System.Globalization": "4.0.11", "System.IO": "4.1.0", "System.Linq": "4.1.0", "System.Linq.Expressions": "4.1.0", "System.ObjectModel": "4.0.12", "System.Reflection": "4.1.0", "System.Reflection.Extensions": "4.0.1", "System.Resources.ResourceManager": "4.0.1", "System.Runtime": "4.1.0", "System.Runtime.Extensions": "4.1.0", "System.Runtime.Serialization.Primitives": "4.1.1", "System.Text.Encoding": "4.0.11", "System.Text.Encoding.Extensions": "4.0.11", "System.Text.RegularExpressions": "4.1.0", "System.Threading": "4.0.11", "System.Threading.Tasks": "4.0.11", "System.Xml.ReaderWriter": "4.0.11", "System.Xml.XDocument": "4.0.11" }, "runtime": { "lib/netstandard1.0/Newtonsoft.Json.dll": { "assemblyVersion": "9.0.0.0", "fileVersion": "9.0.1.19813" } } },

@github-actions github-actions bot added the untriaged To be investigated label Feb 9, 2024
@Bertk Bertk added the duplicate This issue or pull request already exists label Feb 9, 2024
@Bertk
Copy link
Collaborator

Bertk commented Feb 9, 2024

duplicate issue #1505

the next coverlet release will not use Newtonsoft.Json anymore.

@Bertk Bertk added Solved The issue is solved and can be closed and removed untriaged To be investigated labels Feb 9, 2024
@Duranom
Copy link

Duranom commented Feb 19, 2024

Bit rude to ask, but any idea around when to expect that release?
The package issue raised can be flagged as trivial due how it is used, but would be nice to remove that rule 😊

@akutuev
Copy link

akutuev commented Feb 20, 2024

Bit rude to ask, but any idea around when to expect that release? The package issue raised can be flagged as trivial due how it is used, but would be nice to remove that rule 😊

We have the similar problem, but apparently it was fixed today in version 6.0.1

Many thanks!

@Bertk
Copy link
Collaborator

Bertk commented Feb 20, 2024

coverlet V6.0.1 is released.

@Bertk Bertk closed this as completed Feb 20, 2024
@akutuev
Copy link

akutuev commented Feb 20, 2024

coverlet V6.0.1 is released.

Sorry, any ideas when it will be published to Nuget?

@daveMueller
Copy link
Collaborator

Sorry, any ideas when it will be published to Nuget?

It's now also available in the NuGet Gallery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists Solved The issue is solved and can be closed
Projects
None yet
Development

No branches or pull requests

5 participants