feat(config): reorder configuration precedence #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheKevJames
force-pushed
the
config-precedence
branch
2 times, most recently
from
26e28a9
to
29dce07
Compare
We've been getting a slew of cases where users are reporting requiring different configurations -- especially Github Actions, where we seem to need to set a different service name on a case-by-case basis. Reordering our configuration precedence such that user-specified values overwrite the CI defaults should allow users to fix these problems without requiring a one-size-fits-all code change. This is massively backwards incompatible for anyone with the same key set to two different values in their configs.
TheKevJames
force-pushed
the
config-precedence
branch
from
29dce07
to
66caaa7
Compare
Harmon758
added a commit
to Harmon758/tweepy
that referenced
this pull request
Jan 12, 2021
This was referenced Mar 12, 2021
andy-maier
pushed a commit
to andy-maier/coveralls-python
that referenced
this pull request
Dec 23, 2022
We've been getting a slew of cases where users are reporting requiring different configurations -- especially Github Actions, where we seem to need to set a different service name on a case-by-case basis. Reordering our configuration precedence such that user-specified values overwrite the CI defaults should allow users to fix these problems without requiring a one-size-fits-all code change. This is massively backwards incompatible for anyone with the same key set to two different values in their configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.