Docs: Fixes on COVERALLS_FLAG_NAME and COVERALLS_REPO_TOKEN for GitHub Actions #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b Actions Details: * The docs section 'Github Actions Gotcha' stated that the COVERALLS_FLAG_NAME env var is needed in order to avoid 'pile up of jobs'. It turns out that it is optional, and when specified, can be specified with the same value across all jobs or with unique values. This change clarifies that in the documentation. * This change also clarifies that the COVERALLS_REPO_TOKEN env var is not needed for GitHub Actions. * This change also renames the heading of the section to 'Github Actions support' to have a more neutral name. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
TheKevJames
reviewed
Nov 19, 2020
There was a problem hiding this comment.
@andy-maier thanks for the contribution, and I appreciate you helping to clean things up here. As you mentioned in #243, I think it would be useful to mention something about the "piling up" of jobs, even if it's not something we can fix. Could you include something to that effect here, to make sure users know that is expected?
|
Merging as this is a net improvement, but would love if you (@andy-maier ) had more info to add on the "piling up jobs" thing! |
andy-maier
added a commit
to andy-maier/coveralls-python
that referenced
this pull request
Dec 23, 2022
Details: * The docs section 'Github Actions Gotcha' stated that the COVERALLS_FLAG_NAME env var is needed in order to avoid 'pile up of jobs'. It turns out that it is optional, and when specified, can be specified with the same value across all jobs or with unique values. This change clarifies that in the documentation. * This change also clarifies that the COVERALLS_REPO_TOKEN env var is not needed for GitHub Actions. * This change also renames the heading of the section to 'Github Actions support' to have a more neutral name. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #243