Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhashable exception #230

Merged
merged 2 commits into from Jul 8, 2020
Merged

Fix unhashable exception #230

merged 2 commits into from Jul 8, 2020

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Jul 8, 2020

Fixes #229

@rodrigc rodrigc requested a review from TheKevJames as a code owner July 8, 2020 07:16
@TheKevJames
Copy link
Owner

@rodrigc appreciate the quick fix, thanks!

@TheKevJames TheKevJames merged commit aa55335 into TheKevJames:master Jul 8, 2020
@rodrigc rodrigc deleted the fix-unhashable-exception branch July 8, 2020 18:55
@rodrigc
Copy link
Contributor Author

rodrigc commented Jul 16, 2020

@TheKevJames Thanks for merging the fix. I can confirm that it works. In the Twisted project, I am occasionally seeing errors, such as the one at this link: https://travis-ci.com/github/twisted/twisted/jobs/361796000

that look like:

Submitting coverage to coveralls.io...
Could not submit coverage: 504 Server Error: Gateway Time-out for url: https://coveralls.io/api/v1/jobs
Traceback (most recent call last):
  File "/home/travis/build/twisted/twisted/build/coveralls-push/lib/python3.6/site-packages/coveralls/api.py", line 205, in wear
    response.raise_for_status()
  File "/home/travis/build/twisted/twisted/build/coveralls-push/lib/python3.6/site-packages/requests/models.py", line 941, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 504 Server Error: Gateway Time-out for url: https://coveralls.io/api/v1/jobs

Is there a problem on the coveralls server?

@rodrigc
Copy link
Contributor Author

rodrigc commented Jul 16, 2020

I also saw this error at https://travis-ci.com/github/twisted/twisted/jobs/361796000


coveralls-push run-test: commands[1] | coveralls
Submitting coverage to coveralls.io...
Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs
Traceback (most recent call last):
  File "/home/travis/build/twisted/twisted/build/coveralls-push/lib/python3.6/site-packages/coveralls/api.py", line 205, in wear
    response.raise_for_status()
  File "/home/travis/build/twisted/twisted/build/coveralls-push/lib/python3.6/site-packages/requests/models.py", line 941, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/travis/build/twisted/twisted/build/coveralls-push/lib/python3.6/site-packages/coveralls/cli.py", line 85, in main
    result = coverallz.wear()
  File "/home/travis/build/twisted/twisted/build/coveralls-push/lib/python3.6/site-packages/coveralls/api.py", line 208, in wear
    raise CoverallsException('Could not submit coverage: {}'.format(e))
coveralls.exception.CoverallsException: Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs
ERROR: InvocationError for command /home/travis/build/twisted/twisted/build/coveralls-push/bin/coveralls (exited with code 1)

@TheKevJames
Copy link
Owner

Unfortunately, it seems the Coveralls API just isn't all that reliable -- we've gotten a bunch of reports like this (and other coveralls libraries have seen the same sort of thing) and they mostly just amount to intermittent API issues. We're not associated with Coveralls at all, so there's nothing I can do there. The 422 error might be something on our side -- if you can reproduce it within some specific set of inputs, it might be something we can avoid! Feel free to open up an issue if so, I'd be happy to take a look.

@rodrigc
Copy link
Contributor Author

rodrigc commented Jul 21, 2020

Thanks for the response. Yes this was an intermittent problem and I have not hit it lately.
The workaround for me was to push a new commit to my branch so that it would have a new Git SHA, and Coveralls did not error out after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: unhashable type: 'CoverallsException'
2 participants