Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): rename service to github-actions #209

Merged
merged 1 commit into from Dec 3, 2019

Conversation

ArturKlauser
Copy link
Contributor

The coveralls API refuses to accept submissions with service=github, but accepts
submissions with service=github-actions.

The coveralls API refuses to accept submissions with service=github, but accepts
submissions with service=github-actions.
@ArturKlauser
Copy link
Contributor Author

ArturKlauser commented Dec 3, 2019

I fear that your commit docs(circleci): token is now required has broken your circleci tests for PRs. They all fail their last stage, sending data to coveralls with:

CoverallsException: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.
ERROR: InvocationError for command /root/project/.tox/coveralls/bin/coveralls --verbose (exited with code 1)

@TheKevJames
Copy link
Owner

Looks like I just forgot to check the button for having CircleCI pass secrets to PR builds -- tests pass upon re-running.

This LGTM as well -- I'll get this deployed as v1.9.2. Let me know if you continue to have any issues!

@ArturKlauser
Copy link
Contributor Author

Thanks, v1.9.2 works like a charm now.
If you ever run across why the coveralls API rejects service='github' let me know, I'm curious.

@ArturKlauser ArturKlauser deleted the github-action-fix branch December 3, 2019 23:17
@TheKevJames
Copy link
Owner

@ArturKlauser you may be interested to know that the Coveralls API seems to now be accepting service='github' -- as of my testing of #216, I've found that this now works perfectly fine.

I still have no idea whatsoever... but (just guessing here) maybe it was a bug they finally fixed?

@ArturKlauser
Copy link
Contributor Author

Interesting. Or maybe it is the added service_number that you're now sending that was expected on the server side.

@TheKevJames
Copy link
Owner

As far as I can tell, the service_number is only parsed for parallel builds -- I tried a non-parallel build with service='github' and everything seemed to work just fine. May have missed something, of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants