Skip to content

update for gjf v1.8 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2020
Merged

update for gjf v1.8 #61

merged 3 commits into from
Jun 3, 2020

Conversation

shua
Copy link
Contributor

@shua shua commented May 4, 2020

  • update google-java-format dependency to version 1.8
  • JavadocOnlyImports was removed, so remove reference to it
  • reorderImports(String) is deprecated, use recommended reorderImports(String, Style)
  • build still failing due to some maven-plugin-plugin errors I didn't understand, but updating the plugin version seemed to fix it, anything else I tried didn't

@shua
Copy link
Contributor Author

shua commented May 4, 2020

example of maven-plugin-plugin errors:

[INFO] --- maven-plugin-plugin:3.5:descriptor (default-descriptor) @ fmt-maven-plugin ---
[INFO] Using 'UTF-8' encoding to read mojo source files.
[INFO] java-javadoc mojo extractor found 0 mojo descriptor.
[ERROR] Failed to analyze /Users/jllore467/.m2/repository/com/google/googlejavaformat/google-java-format/1.8/google-java-format-1.8.jar!/com/google/googlejavaformat/CommentsHelper.class

@shua
Copy link
Contributor Author

shua commented May 5, 2020

cc @malaporte because I see you reviewed/merged the last upgrade PR

@shua
Copy link
Contributor Author

shua commented May 5, 2020

it seems travis is broken, as it failed to simply download the jdk

IncPlusPlus added a commit to IncPlusPlus/bigtoolbox-network that referenced this pull request May 9, 2020
@ericbn
Copy link

ericbn commented May 13, 2020

@shua, looks like "oraclejdk8" is not supported anymore by Travis. And also the minimum supported runtime version for google-java-format 1.8 is now JDK 11, so you might need to update the .travis.yml file with:

jdk:
- openjdk11

@shua
Copy link
Contributor Author

shua commented May 13, 2020

Thanks @ericbn looks like that worked. cc @malaporte again, as this PR is ready to merge.

@shua
Copy link
Contributor Author

shua commented Jun 2, 2020

@malaporte (thank you for this project)
image

@malaporte malaporte merged commit 9772b5e into spotify:master Jun 3, 2020
@malaporte
Copy link
Contributor

HAHAHAHA ok so this definitively got my attention. Sorry - I've been neglecting my GitHub notifications somewhat lately. I'll publish a new release right away.

@shua shua deleted the gjf1.8 branch June 3, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants