Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure msgUpdateClient is not nil before appending to batch in sendBatchMessages #1406

Open
LeTrongDat opened this issue Feb 21, 2024 · 1 comment
Assignees

Comments

@LeTrongDat
Copy link

In the function sendBatchMessages, there is a logic to prepend mp.msgUpdateClient to the beginning of the batch. However, in cases where needsClientUpdate is false, msgUpdateClient will be nil. This can lead to appending a nil value into the batch, which is likely unintended and could cause issues downstream. It's necessary to introduce a check to ensure msgUpdateClient is not nil before appending it to the batch. This precaution would prevent potential errors or unexpected behavior during the message processing workflow.

@jtieri jtieri self-assigned this Apr 23, 2024
@jtieri
Copy link
Member

jtieri commented Apr 23, 2024

Hey @LeTrongDat I think this was also fixed in #1407, does that seem correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants