Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong port (7507 -> 5183)? #1287

Open
taitruong opened this issue Sep 7, 2023 · 3 comments
Open

Wrong port (7507 -> 5183)? #1287

taitruong opened this issue Sep 7, 2023 · 3 comments

Comments

@taitruong
Copy link

Should be port 5183 not 7597 - just tested it.

it will be helpful to provide the output from `http://localhost:7597/debug/pprof/goroutine?debug=2` at a minimum.

@taitruong
Copy link
Author

Port defined here:

APIListenPort: ":5183",

@taitruong
Copy link
Author

taitruong commented Sep 7, 2023

Is this correct? https://github.com/cosmos/relayer/blob/7b073b3aeb2e77d2dcf3d5e05223b0e4a9c87f93/cmd/flags.go#L59C1-L65

const (
	// 7597 is "RLYR" on a telephone keypad.
	// It also happens to be unassigned in the IANA port list.
	defaultDebugAddr = "localhost:7597"

	blankValue = "blank"
)

@taitruong taitruong changed the title Wrong port in doc Wrong port (7507 -> 5183)? Sep 7, 2023
@jtieri
Copy link
Member

jtieri commented Oct 11, 2023

Is this correct? https://github.com/cosmos/relayer/blob/7b073b3aeb2e77d2dcf3d5e05223b0e4a9c87f93/cmd/flags.go#L59C1-L65

const (
	// 7597 is "RLYR" on a telephone keypad.
	// It also happens to be unassigned in the IANA port list.
	defaultDebugAddr = "localhost:7597"

	blankValue = "blank"
)

before the introduction of the prometheus metrics we consumed this default value but it looks like we no longer use it anywhere and it's dead code and the docs need to be updated to reflect these changes. APIListenPort also used to serve another function in the codebase iirc and I think the name also needs to be changed because it's slightly confusing. This should really be a full URI + port

relayer/cmd/start.go

Lines 97 to 115 in 892e52c

debugAddr := a.config.Global.APIListenPort
debugAddrFlag, err := cmd.Flags().GetString(flagDebugAddr)
if err != nil {
return err
}
if debugAddrFlag != "" {
debugAddr = debugAddrFlag
}
if debugAddr == "" {
a.log.Info("Skipping debug server due to empty debug address flag")
} else {
ln, err := net.Listen("tcp", debugAddr)
if err != nil {
a.log.Error("Failed to listen on debug address. If you have another relayer process open, use --" + flagDebugAddr + " to pick a different address.")
return fmt.Errorf("failed to listen on debug address %q: %w", debugAddr, err)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants