Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Set Security: investigate the PFM issue for the reward distribution #1634

Open
Tracked by #853
sainoe opened this issue Feb 9, 2024 · 0 comments
Open
Tracked by #853
Labels
status: waiting-triage This issue/PR has not yet been triaged by the team.

Comments

@sainoe
Copy link
Contributor

sainoe commented Feb 9, 2024

Problem description:

In the PSS reward distribution logic, consumer chains are identified from the IBC path used to send rewards. It allows tracking the rewards received for each consumer chain and allocating them to opted-in validators.

This causes a problem if, for instance, Stride wants to send native Noble USDCs as rewards to the HUB, because it requires unwinding the denom by sending it through Noble. In this scenario, rewards will be allocated to Noble instead of Stride.

For more context, see this comment.

Potential solution

An alternative would be to use the memo or any other field that the sending chain can write to identify the source, which would be durable when passed through Noble's PFM.

PFM code ref

Solving Criteria

Ensure the rewards are allocated to the sender consumer chain

Note: keep in mind backward compatibility while changing the consumer logic

@github-actions github-actions bot added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-triage This issue/PR has not yet been triaged by the team.
Projects
Status: 🤔 F1: Investigate
Development

No branches or pull requests

1 participant