Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change consumer proposal whitelist -> blacklist (or remove the list outright) #1194

Open
5 tasks
asalzmann opened this issue Aug 9, 2023 · 1 comment
Open
5 tasks
Assignees
Labels
good first issue Good for newcomers S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability type: feature-request New feature or request improvement

Comments

@asalzmann
Copy link

Protocol Change Proposal

Summary

Currently, all proposals must be whitelisted on consumer chains. This is not ideal for two reasons

  1. It's hard for consumers to maintain the list of proposals
  2. Providers care about what proposals are blacklisted, not what proposals are whitelisted (e.g. they want to make sure consumers don't slash them, not review the internals of the consumer code)

In practice, slashing on providers is governance gated anyway. Even if slashing weren't gated, it's unclear how much protection providers actually get from the whitelist, because software upgrades (whitelisted) and bugs can cause provider slashing.

At a minimum, I'd propose changing the whitelist on consumers to a blacklist, so consumers don't have to maintain long lists of whitelisted proposals.

It might also make sense to remove the whitelist/blacklist entirely, since it doesn't offer much protection and adds complexity.

Problem Definition

What problems may be addressed by introducing this change?

  • consumers can't easily maintain the whitelist
  • providers can't easily review the whitelist
    What benefits does ICS stand to gain by including this change?
  • ICS code is simpler to reason about and easier to maintain
    Are there any disadvantages of including this change?
  • changes to the whitelist might be flagged in reviewing an upgrade proposal, whereas if a blacklist is used, new props could be introduced on consumers and would be harder for reviewers to surface

Proposal

Remove the proposal whitelisting logic from consumers (please let me know if I should add more details here)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@asalzmann asalzmann added status: waiting-triage This issue/PR has not yet been triaged by the team. type: protocol-change A protocol change proposal labels Aug 9, 2023
@strbrian
Copy link

The main disadvantage with having whitelist is that we need to take care of params in dependency modules like sdk, and ibc go, not only our own modules.
So removing the whitelisting logic would be beneficial, I think.

@mpoke mpoke added good first issue Good for newcomers and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Aug 11, 2023
@insumity insumity self-assigned this Aug 14, 2023
@mpoke mpoke assigned mmulji-ic and unassigned insumity Aug 14, 2023
@mpoke mpoke added the S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability label Sep 14, 2023
@mpoke mpoke added type: feature-request New feature or request improvement and removed type: protocol-change A protocol change proposal labels Apr 11, 2024
@mpoke mpoke self-assigned this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability type: feature-request New feature or request improvement
Projects
Status: 📥 F2: Todo
Development

No branches or pull requests

5 participants