Implement efficient conversion from String, Vec<u8> and &[u8] for identifiers #959
Labels
O: optimization
Objective: aims to optimize performance, allocations and computations
Comments
7 tasks
mina86
added a commit
to mina86/ibc-rs
that referenced
this issue
Nov 10, 2023
Firstly, remove asserts from the validate_identifier_length and validate_prefix_length functions. Instead, let the regular checks handle cases where min and max constraints don’t allow for a valid prefix to exist. Secondly, ensure minimum length constraints is at least one. This makes sure that the validation functions will check for empty identifiers and prefixes. This makes empty identifier check in validate_channel_identifier as well as Error::Empty variant unnecessary so get rid of those too. Lastly, collapse all checks in validate_prefix_length into a single call to validate_identifier_length with correctly adjusted min and max constraints. Issue: cosmos#959
7 tasks
mina86
added a commit
to mina86/ibc-rs
that referenced
this issue
Nov 10, 2023
Firstly, remove asserts from the validate_identifier_length and validate_prefix_length functions. Instead, let the regular checks handle cases where min and max constraints don’t allow for a valid prefix to exist. Secondly, ensure minimum length constraints is at least one. This makes sure that the validation functions will check for empty identifiers and prefixes. This makes empty identifier check in validate_channel_identifier as well as Error::Empty variant unnecessary so get rid of those too. Lastly, collapse all checks in validate_prefix_length into a single call to validate_identifier_length with correctly adjusted min and max constraints. Issue: cosmos#959
rnbguy
added a commit
that referenced
this issue
Nov 13, 2023
* refactor: simplify identifier length validation Firstly, remove asserts from the validate_identifier_length and validate_prefix_length functions. Instead, let the regular checks handle cases where min and max constraints don’t allow for a valid prefix to exist. Secondly, ensure minimum length constraints is at least one. This makes sure that the validation functions will check for empty identifiers and prefixes. This makes empty identifier check in validate_channel_identifier as well as Error::Empty variant unnecessary so get rid of those too. Lastly, collapse all checks in validate_prefix_length into a single call to validate_identifier_length with correctly adjusted min and max constraints. Issue: #959 * log * Update 960-simplify-length-validation.md Signed-off-by: Michal Nazarewicz <mina86@mina86.com> * tests * Update and rename 960-simplify-length-validation.md to 961-simplify-length-validation.md Signed-off-by: Michal Nazarewicz <mina86@mina86.com> * update changelog entry * revert error variant deletion * refactor id validation tests * use numeral consistently --------- Signed-off-by: Michal Nazarewicz <mina86@mina86.com> Co-authored-by: Ranadeep Biswas <mail@rnbguy.at>
Farhad-Shabani
added
the
O: optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Let’s look at ClientId for example. Suppose I have a client id as a String. There’s currently no way to convert that String into ClientId without performing an allocation. The two available constructors are ClientId::from_str (which takes a str slice and then allocates a string) and Client::new (which takes client type and counter and than formats a new id).
The feature request is to provide TryFrom implementations for the identifiers which take ownership of the passed String.
Going further, I’d also love to see constructors which take Vec and &[u8] arguments and skip UTF-8 verification checking. Currently, user has to first get a String or &str and then pass that to identifier’s constructor. However, constructors already check if the string consists of valid characters so they might work on byte slices just as easily and after performing verification convert them to strings.
The text was updated successfully, but these errors were encountered: