Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockConsensusState should not have commitment root #1216

Open
rnbguy opened this issue May 7, 2024 · 0 comments
Open

MockConsensusState should not have commitment root #1216

rnbguy opened this issue May 7, 2024 · 0 comments
Assignees
@rnbguy

Comments

@rnbguy
Copy link
Collaborator

rnbguy commented May 7, 2024 •
edited

Improvement Summary

mock::ConsensusState from ibc_proto doesn't have any commitment root.

Proposal

To avoid any unexpected assumptions, we should also remove commitment_root from MockConsensuState in ibc-testkit. The ConsensusState::root implementation should return a constant value.

Ref: #1052 (comment)
@rnbguy rnbguy self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnbguy rnbguy

Labels
None yet
Projects
ibc-rs
Status: 📥 To Do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rnbguy