Update the feature list of parity-scale-codec dependency

[rnbguy]

ibc-rs/Cargo.toml

Line 107 in 5e7ff8e

parity-scale-codec = { version = "3.6.5", default-features = false, features = ["full"] }

"full" feature is deprecated and doesn't enable anything. Rather this should be "derive".

---

Although, there is an interesting scenario with scale-info dependency.

#[derive(parity_scale_codec::Encode, parity_scale_codec::Decode)]
pub struct Signer(String);

the above doesn't compile with

[dependencies]
parity-scale-codec = { version = "3.6.5", default-features = false }

or

[dependencies]
parity-scale-codec = { version = "3.6.5", default-features = false, features = ["full"] }

but with the following it compiles

[dependencies]
parity-scale-codec = { version = "3.6.5", default-features = false }
scale-info         = { version = "2.10.0", default-features = false }

of course it also compiles with

[dependencies]
parity-scale-codec = { version = "3.6.5", default-features = false, features = ["derive"] }

[seanchen1991]

You mention two possible options that successfully compile. Should we go with the first or the second?

[seanchen1991]

Actually, I see that you touched this code 3 weeks ago (though the parity-scale-codec dependency still has features = [ "full" ] enabled). Is this issue still relevant?

[rnbguy]

It is still relevant 🙂 I modified those lines in chore(deps) PR. but I forgot to take care of this issue 😅

[rnbguy]

You mention two possible options that successfully compile. Should we go with the first or the second?

It should be something like this,

parity-scale-codec = { version = "3.6.5", default-features = false, features = [ "derive" ] }
scale-info         = { version = "2.10.0", default-features = false }