Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for registering both IBC apps and lightclients through the IBCKeeper type #6146

Open
3 tasks
damiannolan opened this issue Apr 11, 2024 · 0 comments
Labels
core needs discussion Issues that need discussion before they can be worked on

Comments

@damiannolan
Copy link
Member

damiannolan commented Apr 11, 2024

Add apis to allow for registering/adding routes of both ibc applications and lightclient modules through the IBCKeeper as one logical point.

I'm not sure this is the ideal approach but came to mind as something I thought was worth discussing - It may be applicable for depinject work as mentioned below, maybe not!

I think there's some other improvements we could probably make to APIs of the core IBCKeeper.
For example right now we require users to create a port router in app.go and bind ibc appmodules there, similarly we retrieve the new light client module router from the clientKeeper and AddRoute for each light client module.

It may be nice to have everything flow through the IBCKeeper, as it essentially is a facade around the set of submodules which make up core ibc.

e.g. IBCKeeper.RegisterClientModule(lightClient) and IBCKeeper.RegisterIBCApplication or something like that, could be useful at some point, maybe these changes may be warranted with depinject work so I think we can hold off on them for now and discuss later. Feel free to drop any thoughts 💭

Originally posted by @damiannolan in #6138 (comment)

Tasks

@damiannolan damiannolan added core needs discussion Issues that need discussion before they can be worked on labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core needs discussion Issues that need discussion before they can be worked on
Projects
Status: Backlog 🕐
Development

No branches or pull requests

1 participant