You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add apis to allow for registering/adding routes of both ibc applications and lightclient modules through the IBCKeeper as one logical point.
I'm not sure this is the ideal approach but came to mind as something I thought was worth discussing - It may be applicable for depinject work as mentioned below, maybe not!
I think there's some other improvements we could probably make to APIs of the core IBCKeeper.
For example right now we require users to create a port router in app.go and bind ibc appmodules there, similarly we retrieve the new light client module router from the clientKeeper and AddRoute for each light client module.
It may be nice to have everything flow through the IBCKeeper, as it essentially is a facade around the set of submodules which make up core ibc.
e.g. IBCKeeper.RegisterClientModule(lightClient) and IBCKeeper.RegisterIBCApplication or something like that, could be useful at some point, maybe these changes may be warranted with depinject work so I think we can hold off on them for now and discuss later. Feel free to drop any thoughts 💭
Add apis to allow for registering/adding routes of both ibc applications and lightclient modules through the
IBCKeeper
as one logical point.I'm not sure this is the ideal approach but came to mind as something I thought was worth discussing - It may be applicable for depinject work as mentioned below, maybe not!
Originally posted by @damiannolan in #6138 (comment)
Tasks
The text was updated successfully, but these errors were encountered: