Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport #589 #603 to v2.0.x #611

Merged
merged 4 commits into from Dec 15, 2021
Merged

backport #589 #603 to v2.0.x #611

merged 4 commits into from Dec 15, 2021

Conversation

crodriguezvega
Copy link
Contributor

Backport #589 and #603.

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

colin-axner and others added 3 commits December 7, 2021 13:06
@colin-axner
backport #589
051ce81
@seantking
fix: emit channel event instead of connection (#603)
b711de6 
* fix: emit channel event instead of connection

* chore: changelog

* chore: remove unncessary import
backport #603
fb13f23
@faddat
Copy link
Contributor

faddat commented Dec 11, 2021 •
edited

lgtm for happier gaia

https://twitter.com/gadikian/status/1469512833809678342

This was referenced Dec 11, 2021
Closed
Closed
Closed
@crodriguezvega crodriguezvega merged commit e1ac41a into release/v2.0.x Dec 15, 2021
@crodriguezvega crodriguezvega deleted the carlos/backport-589-603-to-v2.0.x branch December 15, 2021 13:05
faddat pushed a commit to notional-labs/ibc-go that referenced this pull request Feb 23, 2022
@alpe
Ensure query isolation (cosmos#611)
a447ee0 
* Ensure query isolation

* Review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiannolan damiannolan damiannolan approved these changes

@seantking seantking seantking approved these changes

@colin-axner colin-axner colin-axner approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@charleenfei charleenfei Awaiting requested review from charleenfei charleenfei is a code owner

@fedekunze fedekunze Awaiting requested review from fedekunze fedekunze is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crodriguezvega @faddat @damiannolan @seantking @colin-axner