Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using a custom docker client and network for E2E tests #6030

Open
3 tasks
chatton opened this issue Mar 20, 2024 · 0 comments
Open
3 tasks

Enable using a custom docker client and network for E2E tests #6030

chatton opened this issue Mar 20, 2024 · 0 comments
Labels
e2e type: productivity Increase dev productivity and throughput by improving developer tooling, infrastructure, automation

Comments

@chatton
Copy link
Contributor

chatton commented Mar 20, 2024

Summary

For more involved tests, it can be necessary to perform more low level docker operations. E.g. in the rollkit feature branch, in order to create standalone celestia container, it is also required to ensure the remainder of the containers in chainA and chainB are also deployed on the same docker network.

I did a quick implementation here

client := chainOptions.DockerClient
network := chainOptions.DockerNetwork
if chainOptions.DockerNetwork == "" && chainOptions.DockerClient == nil {
client, network = interchaintest.DockerSetup(s.T())
}
to get the E2E working, this implementation may be sufficient, we just need to add a bit of validation to the network and DockerClient fields, you must specify either both or neither for this to be correct.

This validation is not currently implemented on the linked branch.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@chatton chatton added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. e2e labels Mar 20, 2024
@chatton chatton changed the title [E2E] Enable using a custom docker client and network for tests Enable using a custom docker client and network for E2E tests Mar 20, 2024
@crodriguezvega crodriguezvega added type: productivity Increase dev productivity and throughput by improving developer tooling, infrastructure, automation and removed type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e type: productivity Increase dev productivity and throughput by improving developer tooling, infrastructure, automation
Projects
None yet
Development

No branches or pull requests

2 participants