Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move initialization of storeProvider to light client modules #6009

Open
2 of 3 tasks
DimitrisJim opened this issue Mar 15, 2024 · 1 comment · May be fixed by #6028
Open
2 of 3 tasks

Move initialization of storeProvider to light client modules #6009

DimitrisJim opened this issue Mar 15, 2024 · 1 comment · May be fixed by #6028
Labels
02-client needs discussion Issues that need discussion before they can be worked on

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Mar 15, 2024 •
edited

Based on these two comments: #5806 (comment) and #5806 (comment). Opening to keep track as a point of discussion.

Will try to do a minor investigation pre v9 audit to see if something is stopping this change from occurring and will update issue.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added needs discussion Issues that need discussion before they can be worked on 02-client labels Mar 15, 2024
@damiannolan
Copy link
Member

Happy to discuss this, I do agree that its kind of weird to inject it via the interface method on AddRoute. It might just be cleaner to give it to client module on instantiation

@DimitrisJim DimitrisJim linked a pull request Mar 20, 2024 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02-client needs discussion Issues that need discussion before they can be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass keys to light client modules during initialization. cosmos/ibc-go
2 participants
@damiannolan @DimitrisJim