Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove IBCMiddleware.refundTimeout as it is no longer used #189

Closed
ysv opened this issue May 1, 2024 · 2 comments · Fixed by #193
Closed

chore: remove IBCMiddleware.refundTimeout as it is no longer used #189

ysv opened this issue May 1, 2024 · 2 comments · Fixed by #193
Assignees

Comments

@ysv
Copy link

ysv commented May 1, 2024

I was trying to understand meaning of refundTimeout inside IBCMiddleware but didn't find any usage of this attribute except initialization (3 times) and unit test (2 times) - see screenshot.

I'm still wondering what is the reason behind and if it should be present at all.

Screenshot 2024-05-01 at 17 47 15
@ysv ysv changed the title bug: IBCMiddleware.refundTimeout is not used anywhere except initialization (v7.1.3 & main: 8e64543) bug: IBCMiddleware.refundTimeout is not used anywhere except initialization & tests (v7.1.3 & main: 8e64543) May 1, 2024
@Reecepbcups
Copy link
Member

cc @jtieri since you did a bit of refund work iirc due to Mandrake

@agouin
Copy link
Member

agouin commented May 21, 2024

This parameter is no longer used after the introduction of atomic acks. It can be safely ignored (set to arbitrary value) and should be removed in a future release

@Reecepbcups Reecepbcups changed the title bug: IBCMiddleware.refundTimeout is not used anywhere except initialization & tests (v7.1.3 & main: 8e64543) chore: remove IBCMiddleware.refundTimeout as it is no longer used May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants