(Bug?) ResponseQuery Data changed from Value to Key

[dferendo]

We noticed from testing that the data encoded in the ResponseQuery on the host side was changed to be stored into Key instead of Value when changing versions from v7.0.0 to v7.1.1. The tests were ran using both osmosis and juno, unfortunately cannot provide the e2e test since it is in a private repo currently. We can spin up a test on this repo for further proof if required.

There was no mention of this change in the CHANGELOG and we were wondering whether this change was intentional. Thanks!

[Reecepbcups]

@dferendo Thanks for the report. This change was not intentional as I can see.
The only file that was modified with any reference to abci.ResponseQuery is:

git diff modules/async-icq/v7.0.0 modules/async-icq/v7.1.1 -- modules/async-icq/keeper/relay.go > ~/Desktop/relay.diff

A new applyFuncIfNoError was added but nothing in the function indicates to me why it would swap key / value pairings here. executeQuery remains untouched... hmm

Did the function previously panic on v7.0.0?

[dferendo]

No, the function was a normal balance query and the data is still correct, just stored in the wrong variable.

[dferendo]

@Reecepbcups

Looking more into it, it seems that SerializeCosmosResponse is returning different bytes between the two versions. We checked the data in this unit test.

v7.0.0 returns
eyJkYXRhIjoiQ2dRNkFoSUEifQ==

v7.1.1 returns
eyJkYXRhIjoiQ2dReUFoSUEifQ==

We used base64 encoding to obtain the above base64.StdEncoding.EncodeToString(bz).

[migueldingli1997]

Turns out this particular unit test is mostly likely returning different bytes because of the address which is different for each test run. That being said we're still experiencing this issue but haven't narrowed it down enough.