Skip to content

fix: missing lock in DeleteVersionsFrom #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Dec 7, 2022

it seems need to hold this lock.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
yihuang yihuang
@yihuang yihuang requested a review from a team December 7, 2022 08:18

Verified

This commit was signed with the committer’s verified signature. The key has expired.
yihuang yihuang

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a regression test we can add for delete here?

@yihuang
Copy link
Contributor Author

yihuang commented Dec 7, 2022

is there a regression test we can add for delete here?

LoadVersionForOverwriting is tested in tree_random_test.go, but I guess it's not easy to reveal these issues, I only realize this when refactoring the code.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tac0turtle tac0turtle merged commit 7c04bc4 into cosmos:master Dec 14, 2022
@tac0turtle
Copy link
Member

@Mergifyio backport release/v0.19.x

mergify bot pushed a commit that referenced this pull request Dec 14, 2022
Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 7c04bc4)
@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

backport release/v0.19.x

✅ Backports have been created

tac0turtle pushed a commit that referenced this pull request Dec 16, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: yihuang <huang@crypto.com>
ankurdotb pushed a commit to cheqd/iavl that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants