From d99b56f153e1b6792b5b64f91c52b24edb321128 Mon Sep 17 00:00:00 2001 From: Jeancarlo Date: Mon, 28 Nov 2022 15:50:30 -0500 Subject: [PATCH 1/4] fix(baseapp): fix snapshot interval bug --- baseapp/options.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/baseapp/options.go b/baseapp/options.go index f41f4e961ab2..b45a71985738 100644 --- a/baseapp/options.go +++ b/baseapp/options.go @@ -216,7 +216,7 @@ func (app *BaseApp) SetSnapshot(snapshotStore *snapshots.Store, opts snapshottyp if app.sealed { panic("SetSnapshot() on sealed BaseApp") } - if snapshotStore == nil || opts.Interval == snapshottypes.SnapshotIntervalOff { + if snapshotStore == nil { app.snapshotManager = nil return } From 0fdc9c288405be4fcf51794764289c55982e4006 Mon Sep 17 00:00:00 2001 From: Jeancarlo Date: Mon, 28 Nov 2022 16:33:37 -0500 Subject: [PATCH 2/4] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3c58fdbd8d8c..9c19c760d1e7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -207,6 +207,7 @@ extension interfaces. `module.Manager.Modules` is now of type `map[string]interf * (server) [#13778](https://github.com/cosmos/cosmos-sdk/pull/13778) Set Cosmos SDK default endpoints to localhost to avoid unknown exposure of endpoints. * (x/auth) [#13877](https://github.com/cosmos/cosmos-sdk/pull/13877) Handle missing account numbers during `InitGenesis`. * (x/gov) [#13918](https://github.com/cosmos/cosmos-sdk/pull/13918) Fix propagation of message errors when executing a proposal. +* (baseapp)[#14049](https://github.com/cosmos/cosmos-sdk/pull/14049) Fix state sync when interval is cero ### Deprecated From f53822b6957691b8ac76d410c3840ef19fa9d750 Mon Sep 17 00:00:00 2001 From: Jeancarlo Barrios Date: Mon, 28 Nov 2022 16:42:38 -0500 Subject: [PATCH 3/4] Update CHANGELOG.md Co-authored-by: Julien Robert --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9c19c760d1e7..6d47390899d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -207,7 +207,7 @@ extension interfaces. `module.Manager.Modules` is now of type `map[string]interf * (server) [#13778](https://github.com/cosmos/cosmos-sdk/pull/13778) Set Cosmos SDK default endpoints to localhost to avoid unknown exposure of endpoints. * (x/auth) [#13877](https://github.com/cosmos/cosmos-sdk/pull/13877) Handle missing account numbers during `InitGenesis`. * (x/gov) [#13918](https://github.com/cosmos/cosmos-sdk/pull/13918) Fix propagation of message errors when executing a proposal. -* (baseapp)[#14049](https://github.com/cosmos/cosmos-sdk/pull/14049) Fix state sync when interval is cero +* (baseapp)[#14049](https://github.com/cosmos/cosmos-sdk/pull/14049) Fix state sync when interval is zero. ### Deprecated From 21a009d1047557d248a69f4dc97dcb59284de243 Mon Sep 17 00:00:00 2001 From: Jeancarlo Date: Mon, 28 Nov 2022 16:44:19 -0500 Subject: [PATCH 4/4] remove unesessary variable --- snapshots/types/options.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/snapshots/types/options.go b/snapshots/types/options.go index 1ce39d486adb..9c6ec79a11e2 100644 --- a/snapshots/types/options.go +++ b/snapshots/types/options.go @@ -10,10 +10,6 @@ type SnapshotOptions struct { KeepRecent uint32 } -// SnapshotIntervalOff represents the snapshot interval, at which -// no snapshots are taken. -const SnapshotIntervalOff uint64 = 0 - func NewSnapshotOptions(interval uint64, keepRecent uint32) SnapshotOptions { return SnapshotOptions{ Interval: interval,