Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the usage of go-keychain #5759

Closed
4 tasks
jonioni opened this issue Mar 6, 2020 · 7 comments · Fixed by #12576
Closed
4 tasks

Upgrade the usage of go-keychain #5759

jonioni opened this issue Mar 6, 2020 · 7 comments · Fixed by #12576

Comments

@jonioni
Copy link

jonioni commented Mar 6, 2020

Summary

Upgrade go-keychain

Problem Definition

Encountering the following errors on macOS Catalina 10.15 with CosmosSDK v0.38.1:

cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here

This is reported in keybase/go-keychain #58 and seems to be fixed in keybase/go-keychain #60.

Not sure if this is directly related but it impacts the usage of cosmos chain node on MacOS based machine.

Proposal

Upgrade the corresponding dependency to use a newer version of keybase/go-keychain.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jonioni jonioni changed the title Upgrade the version for go-keychain Upgrade the usage of go-keychain Mar 6, 2020
@alexanderbez
Copy link
Contributor

Thanks @jonioni, we know of this (benign) issue. However, we depend on github.com/99designs/keyring and not keybase/go-keychain directly. While, we could add a replace directive for keybase/go-keychain, it would be annoying as all app developers and projects would have to do the same. In fact, we did this for a short time, but it proved to be a burden.

Unfortunately, we must wait until github.com/99designs/keyring releases an updated version.

@wafeishushu
Copy link

I encounter the same problem.

@gsora
Copy link
Contributor

gsora commented Mar 9, 2021

There's a workaround published by 99Desings VP of Technology here.

Shall we implement it?

@gsora gsora reopened this Mar 9, 2021
@xlab
Copy link

xlab commented Mar 13, 2021

cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]

Still gets everywhere I use cosmos-sdk, I think you should incorporate this into SDK

@17y
Copy link

17y commented Jun 22, 2021

go install -mod=readonly -tags "netgo,ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=wasm -X github.com/cosmos/cosmos-sdk/version.AppName=wasmd -X github.com/cosmos/cosmos-sdk/version.Version=0.17.0 -X github.com/cosmos/cosmos-sdk/version.Commit=d2e35c249e39e90c5a85e03e0b75800431612b20 -X github.com/CosmWasm/wasmd/app.Bech32Prefix=wasm -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" -L/usr/local/opt/openssl/lib' -trimpath ./cmd/wasmd github.com/keybase/go-keychain cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here

Still facing the same issue when installing wasmd.
Caused by the dependencies

cosmos/cosmos-sdk ->keyring -> go-keychain

OS: macOS Catalina 15.7.1

@vvllxxdd
Copy link

vvllxxdd commented Mar 2, 2022

Still facing this, any solution?

@xlab
Copy link

xlab commented Mar 2, 2022

Screenshot 2022-03-02 at 20 23 30

Just more errors now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants