Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod2nix doesn't support specific go versions #20372

Closed
faddat opened this issue May 13, 2024 · 3 comments
Closed

gomod2nix doesn't support specific go versions #20372

faddat opened this issue May 13, 2024 · 3 comments
Labels
needs-triage Issue that needs to be triaged

Comments

@faddat
Copy link
Contributor

faddat commented May 13, 2024

./x/gov/go.mod
Updating ./store/go.mod
Updating ./store/v2/go.mod
warning: Git tree '/Users/faddat/cosmos-sdk' is dirty
INFO[0000] Parsing go.mod                                modPath=go.mod
INFO[0000] Downloading dependencies                     
INFO[0000] Done downloading dependencies                
INFO[0000] Wrote: gomod2nix.toml                        
INFO[0000] Parsing go.mod                                modPath=go.mod
panic: error generating pkgs: go.mod:3: invalid go version '1.22.2': must match format 1.23

goroutine 1 [running]:
github.com/nix-community/gomod2nix/internal/cmd.generateFunc(0x140000ea700?, {0x1017d8b00?, 0x4?, 0x10135c488?})
	/Users/faddat/go/pkg/mod/github.com/nix-community/gomod2nix@v1.5.0/internal/cmd/root.go:67 +0x324
github.com/spf13/cobra.(*Command).execute(0x10176c240, {0x14000020190, 0x0, 0x0})
	/Users/faddat/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:860 +0x550
github.com/spf13/cobra.(*Command).ExecuteC(0x10176c240)
	/Users/faddat/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:974 +0x318
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/faddat/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:902
github.com/nix-community/gomod2nix/internal/cmd.Execute()
	/Users/faddat/go/pkg/mod/github.com/nix-community/gomod2nix@v1.5.0/internal/cmd/root.go:124 +0x24
main.main()
	/Users/faddat/go/pkg/mod/github.com/nix-community/gomod2nix@v1.5.0/main.go:6 +0x1c
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 13, 2024
@faddat
Copy link
Contributor Author

faddat commented May 13, 2024

@faddat
Copy link
Contributor Author

faddat commented May 14, 2024

can just use the master branch instead of the v1.5.0 release

I'll see if we can do that in ci

@faddat faddat closed this as completed May 14, 2024
@faddat faddat reopened this May 14, 2024
@tac0turtle
Copy link
Member

the changes in the pr pushing the version to .3 will be reverted so we dont need this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Issue that needs to be triaged
Projects
Status: 🥳 Done
Development

No branches or pull requests

2 participants