Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic]: x/Auth #20058

Open
4 tasks
tac0turtle opened this issue Apr 16, 2024 · 1 comment
Open
4 tasks

[Epic]: x/Auth #20058

tac0turtle opened this issue Apr 16, 2024 · 1 comment

Comments

@tac0turtle
Copy link
Member

Summary

The Auth module handles storage of auth information like sequence number, pubkeys, etc.. The module is complex and has limitations in being able to expand the different account types. Recently we completed the accounts module and see a future in which the accounts module offers a baseaccount that mimics the same logic as the auth module. In this design there is not a need for the auth module to continue.

Secondly, we should look into what this means for the cryptocodec, if it is needed any longer as well.

Problem Definition

Accounts provides an simple alternative to the auth module. We should explore using it instead of the auth module.

for existing chains we should explore if a lazy migration would be useful here in order to migrate users from x/auth to x/accounts

Work Breakdown

Tasks

@julienrbrt
Copy link
Member

julienrbrt commented Apr 19, 2024

For the first task we need to remove the auth keeper from simulation.
A module like x/feegrant only imports the auth keeper for getting the address codec and simulation.
The former can be done directly in app.go and depinject knows how to inject an address.Codec directly as well.
The latter is a hard requirement as of now:

account := txCtx.AccountKeeper.GetAccount(txCtx.Context, txCtx.SimAccount.Address)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants