Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client/v2): add encoder for cosmos.base.v1beta1.DecCoin #19976

Merged
merged 6 commits into from Apr 10, 2024
Merged

fix(client/v2): add encoder for cosmos.base.v1beta1.DecCoin #19976

merged 6 commits into from Apr 10, 2024

Conversation

julienrbrt
Copy link
Member

Description

Closes: #19975

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Apr 8, 2024
@julienrbrt julienrbrt requested a review from a team as a code owner April 8, 2024 11:04
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 8, 2024 •
edited

Walkthrough

Walkthrough

This update introduces changes aimed at resolving inaccuracies in displaying DecCoin types when using the autocli for generating client CLI commands. By integrating the cosmossdk.io/math package and refining type encoding and field handling logic for cosmos.base.v1beta1.DecCoin, the modification seeks to ensure that balances and parameters involving DecCoin types are correctly represented in the command line outputs.

Changes

File(s) Change Summary
client/v2/autocli/query.go - Imported cosmossdk.io/math.
- Utilized sdk.NewDecCoinFromDec.
- Defined type encoding for cosmos.base.v1beta1.DecCoin.
client/v2/autocli/common_test.go - Replaced grpc.Dial with grpc.NewClient for establishing a client connection in the test fixture setup.

Assessment against linked issues

Objective Addressed Explanation
Resolve display issue with cosmossdk_io_math.LegacyDec in autocli-generated commands [#19975] ✅
Ensure DecCoin types show correctly in balances and parameters outputs in CLI [#19975] ✅
Compatibility with client.PrintProto() for accurate custom module outputs involving DecCoin [#19975] ✅

The modifications directly address the core issue of incorrect display formats for DecCoin types in CLI outputs generated by autocli, ensuring compatibility with existing PrintProto() functionality for accurate display of custom module outputs. This addresses the primary concerns raised in the linked issue, focusing on the accurate representation of DecCoin types across various modules.

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ba7fdc4 and 1d9d0b3.
Files selected for processing (1)
  • client/v2/autocli/query.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • client/v2/autocli/query.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the C:CLI label Apr 8, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
likhita-809
likhita-809 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit 76bb0cd Apr 10, 2024
61 checks passed
@julienrbrt julienrbrt deleted the julien/encoder-autocli branch April 10, 2024 15:03
mergify bot pushed a commit that referenced this pull request Apr 10, 2024
@julienrbrt @mergify
fix(client/v2): add encoder for cosmos.base.v1beta1.DecCoin (#19976)
52f4c7b 
(cherry picked from commit 76bb0cd)
@mergify mergify bot mentioned this pull request Apr 10, 2024
Merged
12 tasks
julienrbrt added a commit that referenced this pull request Apr 10, 2024
@mergify @julienrbrt
fix(client/v2): add encoder for cosmos.base.v1beta1.DecCoin (backport
525b720 
#19976) (#20001)

Co-authored-by: Julien Robert <julien@rbrt.fr>
alpe added a commit to alpe/cosmos-sdk that referenced this pull request Apr 15, 2024
@alpe
Merge branch 'main' into alex/testnet
183e1ee 
* main: (25 commits)
  fix: Implement gogoproto customtype to secp256r1 keys (cosmos#20027)
  fix(x/epochs): avoid invalid epoch duration in simulation (cosmos#20030)
  fix(x/bank): align query with multi denoms for send-enabled (cosmos#20028)
  refactor(x/slashing)!: remove Accounts String (cosmos#20026)
  refactor(x/evidence)!: remove Address.String() (cosmos#20016)
  chore: make telemetry consistent (cosmos#20025)
  chore: prepare x/tx changelog (cosmos#20015)
  build(deps): Bump actions/add-to-project from 1.0.0 to 1.0.1 (cosmos#20018)
  feat(x/bank): support depinject for send restrictions (cosmos#20014)
  feat: Conditionally emit metrics based on enablement (cosmos#19903)
  fix(store): fix the typo (cosmos#20011)
  docs(x/feegrant): fix allowance typo (cosmos#20000)
  chore(confix): update latest config value (cosmos#20012)
  refactor(x/auth): auth module can recognize x/accounts account (cosmos#20002)
  fix(mempool): use no-op mempool as default (cosmos#19970)
  fix(simapp): add epoch store to upgrade (cosmos#20007)
  test(kv): add unit tests for the helpers functions kv.AssertKeyAtLeas… (cosmos#19965)
  feat(x/tx): Rename custom Amino JSON encoder to "inline_json" (cosmos#19919)
  refactor(x/auth): use transaction service (cosmos#19967)
  fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (cosmos#19976)
  ...
@coderabbitai coderabbitai bot mentioned this pull request Apr 18, 2024
Merged
12 tasks
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@likhita-809 likhita-809 likhita-809 approved these changes

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI
Projects
None yet
Milestone
No milestone
3 participants
@julienrbrt @tac0turtle @likhita-809