Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: REST endpoint /cosmos/bank/v1beta1/supply/{denom} doesn't work with denoms that contain the forward slash symbol (/) #17493

Closed
larry0x opened this issue Aug 21, 2023 · 6 comments
Labels

Comments

@larry0x
Copy link
Contributor

larry0x commented Aug 21, 2023

What happened?

As the title suggests. Issue is with the REST endpoint, gRPC should be fine.

Cosmos SDK Version

0.45+

How to reproduce?

Example: Osmosis denom gamm/pool/1

The following URLs:

https://lcd.osmosis.zone/cosmos/bank/v1beta1/supply/gamm/pool/1

and

https://lcd.osmosis.zone/cosmos/bank/v1beta1/supply/gamm%2Fpool%2F1

both returns

{
  "code": 12,
  "message": "Not Implemented",
  "details": []
}
@larry0x larry0x added the T:Bug label Aug 21, 2023
@alexanderbez
Copy link
Contributor

Blows my mind people still call this LCD...in any case, for these requests, can you just pass a query param?

@facundomedica
Copy link
Member

This is not an issue since v0.46, fixed here: #11170

@apollo-sturdy
Copy link

Seems like this is still an issue for the denom_owners query? It does not seem to work with cosmos/bank/v1beta1/denom_owners/?denom=factory/addr/test.

Any ideas @alexanderbez @facundomedica ?

@alexanderbez
Copy link
Contributor

@apollo-sturdy yes, we'll need to implement a similar query for denom_owners that takes a query string.

@apollo-sturdy
Copy link

@apollo-sturdy yes, we'll need to implement a similar query for denom_owners that takes a query string.

Alright. I'm assuming there might be other issues with that, but if possible another option would be to upgrade grpc-gateway to 2.7.0 which fixes the url encoding bug: grpc-ecosystem/grpc-gateway#2332

@alexanderbez
Copy link
Contributor

alexanderbez commented Dec 22, 2023

I will update and see what happens: #18872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants